taiyang-li commented on code in PR #5839:
URL: https://github.com/apache/incubator-gluten/pull/5839#discussion_r1615681927
##########
gluten-core/src/main/java/org/apache/gluten/vectorized/GeneralOutIterator.java:
##########
@@ -60,10 +61,18 @@ public final void close() {
}
}
+ public final void cancel() {
Review Comment:
It seems hard. Currently `GeneralOutIterator` is used in spark stages to
get output both for Velox and CH. Adding `cancel` only for CH `BatchIterator`
will introduce a series of `if (iter.isInstanceOf[BatchIterator])`. And it it
ugly. I couldn't find a better way to implement it, do you have any ideas?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
