shuai-xu commented on PR #5853: URL: https://github.com/apache/incubator-gluten/pull/5853#issuecomment-2132727543
> @shuai-xu I currently don't have the env for CH, so I used Velox to test the case you provided. The result is consistent with vanilla Spark. Does this issue only occur in CH? Could you tell me what CH returns before the fix? I also tried debugging and did not enter into the code you modified. > > In addition, the original logic here is to reuse some duplicated pulled-out `Attribute`s. If the issue you encountered is only related to `Literal`, could you only add a special handling for `Literal` here? This case only happens in CH. It will throw an exception as shown in the issue before fix. The problem here is that the resue logic consider two different attibutes with same name as same one, so later in CH, it can't know whether they are really same. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
