liujiayi771 commented on code in PR #5853:
URL: https://github.com/apache/incubator-gluten/pull/5853#discussion_r1616507635
##########
gluten-core/src/main/scala/org/apache/gluten/extension/columnar/rewrite/PullOutPreProject.scala:
##########
@@ -158,9 +158,11 @@ object PullOutPreProject extends RewriteSingleNode with
PullOutProjectHelper {
val newAgg = copyBaseAggregateExec(agg)(
newGroupingExpressions = newGroupingExpressions,
newAggregateExpressions = newAggregateExpressions)
- val preProject = ProjectExec(
- eliminateProjectList(agg.child.outputSet, expressionMap.values.toSeq),
- agg.child)
+ // ISSUE-5852: literals with same names are lost in expressionMap, need
addback to Project
Review Comment:
Was the modification of the logic in this code unnecessary in your earliest
version?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
