WangGuangxin commented on code in PR #5626:
URL: https://github.com/apache/incubator-gluten/pull/5626#discussion_r1619585371
##########
gluten-core/src/main/scala/org/apache/gluten/utils/PullOutProjectHelper.scala:
##########
@@ -151,6 +183,22 @@ trait PullOutProjectHelper {
case ae: AggregateExpression => rewriteAggregateExpression(ae,
expressionMap)
case other => other
}
- we.copy(windowFunction = newWindowFunc)
+
+ val newWindowSpec = we.windowSpec.frameSpecification match {
+ case swf: SpecifiedWindowFrame if needPreComputeRangeFrame(swf) =>
+ // This is guaranteed by Spark, but we still check it here
+ if (orderSpecs.size != 1) {
+ throw new GlutenNotSupportException(
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
