WangGuangxin commented on code in PR #5626:
URL: https://github.com/apache/incubator-gluten/pull/5626#discussion_r1619586361
##########
cpp/velox/substrait/SubstraitToVeloxPlan.cc:
##########
@@ -839,23 +840,33 @@ const core::WindowNode::Frame createWindowFrame(
VELOX_FAIL("the window type only support ROWS and RANGE, and the input
type is ", std::to_string(type));
}
- auto boundTypeConversion = [](::substrait::Expression_WindowFunction_Bound
boundType)
+ auto specifiedBound =
+ [&](bool hasOffset, int64_t offset, const ::substrait::Expression&
columnRef) -> core::TypedExprPtr {
+ if (hasOffset) {
+ return std::make_shared<core::ConstantTypedExpr>(BIGINT(),
variant(offset));
+ } else {
+ return exprConverter_->toVeloxExpr(columnRef, inputType);
+ }
+ };
+
+ auto boundTypeConversion = [&](::substrait::Expression_WindowFunction_Bound
boundType)
-> std::tuple<core::WindowNode::BoundType, core::TypedExprPtr> {
- // TODO: support non-literal expression.
if (boundType.has_current_row()) {
return std::make_tuple(core::WindowNode::BoundType::kCurrentRow,
nullptr);
} else if (boundType.has_unbounded_following()) {
return std::make_tuple(core::WindowNode::BoundType::kUnboundedFollowing,
nullptr);
} else if (boundType.has_unbounded_preceding()) {
return std::make_tuple(core::WindowNode::BoundType::kUnboundedPreceding,
nullptr);
} else if (boundType.has_following()) {
+ auto following = boundType.following();
return std::make_tuple(
core::WindowNode::BoundType::kFollowing,
- std::make_shared<core::ConstantTypedExpr>(BIGINT(),
variant(boundType.following().offset())));
+ specifiedBound(following.has_offset(), following.offset(),
following.ref()));
Review Comment:
It's reused both for ROW and RANGE frame, so offset is used for ROW frame
here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
