ulysses-you commented on code in PR #6022:
URL: https://github.com/apache/incubator-gluten/pull/6022#discussion_r1634039708
##########
gluten-core/src/main/scala/org/apache/spark/shuffle/sort/ColumnarShuffleManager.scala:
##########
@@ -20,21 +20,19 @@ import org.apache.spark.{ShuffleDependency, SparkConf,
SparkEnv, TaskContext}
import org.apache.spark.internal.Logging
import org.apache.spark.serializer.SerializerManager
import org.apache.spark.shuffle._
-import org.apache.spark.shuffle.api.ShuffleExecutorComponents
import org.apache.spark.shuffle.sort.SortShuffleManager.canUseBatchFetch
import org.apache.spark.storage.BlockId
import org.apache.spark.util.collection.OpenHashSet
import java.io.InputStream
import java.util.concurrent.ConcurrentHashMap
-import scala.collection.JavaConverters._
-
class ColumnarShuffleManager(conf: SparkConf) extends ShuffleManager with
Logging {
import ColumnarShuffleManager._
- private lazy val shuffleExecutorComponents =
loadShuffleExecutorComponents(conf)
+ private[this] val sortShuffleManager: SortShuffleManager = new
SortShuffleManager(conf)
Review Comment:
`lazy` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
