ulysses-you commented on code in PR #6022:
URL: https://github.com/apache/incubator-gluten/pull/6022#discussion_r1634042870
##########
gluten-core/src/main/scala/org/apache/spark/shuffle/sort/ColumnarShuffleManager.scala:
##########
@@ -143,44 +107,29 @@ class ColumnarShuffleManager(conf: SparkConf) extends
ShuffleManager with Loggin
shouldBatchFetch = shouldBatchFetch
)
} else {
- new BlockStoreShuffleReader(
- handle.asInstanceOf[BaseShuffleHandle[K, _, C]],
- blocksByAddress,
+ sortShuffleManager.getReader(
+ handle,
+ startMapIndex,
+ endMapIndex,
+ startPartition,
+ endPartition,
context,
- metrics,
- shouldBatchFetch = shouldBatchFetch
- )
+ metrics)
}
}
/** Remove a shuffle's metadata from the ShuffleManager. */
override def unregisterShuffle(shuffleId: Int): Boolean = {
- Option(taskIdMapsForShuffle.remove(shuffleId)).foreach {
- mapTaskIds =>
- mapTaskIds.iterator.foreach {
- mapId => shuffleBlockResolver.removeDataByMap(shuffleId, mapId)
- }
- }
- true
+ sortShuffleManager.unregisterShuffle(shuffleId)
Review Comment:
Does it same with before ? The `taskIdMapsForShuffle` is maintained by
`ColumnarShuffleManager` so `sortShuffleManager. unregisterShuffle` will do
nothing since the `taskIdMapsForShuffle` is empty.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
