zml1206 commented on PR #6004: URL: https://github.com/apache/incubator-gluten/pull/6004#issuecomment-2159879892
After this pr, buildSide of q3 changes, I looked at the AQE code, AQE is not in effect. After reOptimize, only when the cost becomes smaller or the physical plan changes, then AQE will take effect, and then the sizeByte of the logical plan will be updated(https://github.com/apache/spark/blob/53d65fd12dd9231139188227ef9040d40d759021/sql/core/src/main/scala/org/apache/spark/sql/execution/adaptive/AdaptiveSparkPlanExec.scala#L383-L392). So buildSide selection need in custom strategy. I will implement creates "more vanilla" plan when the join operators are falling back in another way in the next PR. cc @zhztheplayer -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
