zhztheplayer commented on PR #6004: URL: https://github.com/apache/incubator-gluten/pull/6004#issuecomment-2160375053
Do you think we can append the required changes to this patch? It sounds a little bit risky to fail some plan checks then wait for another PR to land. > I think writing a custom strategy is necessary. My initial idea is to generate a new ShuffledHashJoinExecTemp(sparkJoinExec, buildSide) in the custom strategy, transform ShuffledHashJoinExecTemp in ColumnarOverrides. OK. And you can compare the overall code complexity with current main code. If we can finally simply the code although a custom strategy is still needed, then it sounds worth it to do the refactor. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
