zhztheplayer commented on PR #6106: URL: https://github.com/apache/incubator-gluten/pull/6106#issuecomment-2172017831
Would suggest using `Iterators.wrap.collectReadMillis` to calculate self time with `out time - in time` basis to simplify code. See example https://github.com/apache/incubator-gluten/blob/main/backends-velox/src/main/scala/org/apache/gluten/execution/VeloxAppendBatchesExec.scala#L69 https://github.com/apache/incubator-gluten/blob/e2f90e96146b97c5fef1fad5fe704ce37faa9894/backends-velox/src/main/scala/org/apache/gluten/execution/VeloxAppendBatchesExec.scala#L82 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
