FelixYBW commented on code in PR #6106:
URL: https://github.com/apache/incubator-gluten/pull/6106#discussion_r1643584843
##########
backends-velox/src/main/scala/org/apache/gluten/execution/RowToVeloxColumnarExec.scala:
##########
@@ -145,10 +145,20 @@ object RowToVeloxColumnarExec {
}
}
- def nativeConvert(row: UnsafeRow): ColumnarBatch = {
+ def convertToUnsafeRow(row: InternalRow): UnsafeRow = {
+ row match {
+ case unsafeRow: UnsafeRow => unsafeRow
+ case _ =>
+ converter.apply(row)
+ }
+ }
+
+ override def next(): ColumnarBatch = {
+ val firstRow = it.next()
Review Comment:
why the first row needs to be handled seperately?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
