zml1206 commented on code in PR #6093: URL: https://github.com/apache/incubator-gluten/pull/6093#discussion_r1642424736
########## shims/spark32/src/main/scala/org/apache/spark/sql/execution/adaptive/GlutenCostEvaluator.scala: ########## @@ -0,0 +1,46 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.spark.sql.execution.adaptive + +import org.apache.spark.sql.execution.SparkPlan +import org.apache.spark.sql.execution.joins.ShuffledJoin + +/** + * This [[CostEvaluator]] is to force use the new physical plan when AQE's new physical plan + * contains [[ShuffledJoin]] and cost is the same. + */ +case class GlutenCostEvaluator() extends CostEvaluator { + private var isReOptimize = false + override def evaluateCost(plan: SparkPlan): Cost = { + val simpleCost = + SimpleCostEvaluator.evaluateCost(plan).asInstanceOf[SimpleCost] + var cost = simpleCost.value * 2 + if (isReOptimize && existsShuffledJoin(plan)) { + cost -= 1 + } + isReOptimize = !isReOptimize Review Comment: The planId is increasing, but it may be removed by the parent node, causing the id to become smaller, such as `OptimizeOneRowPlan`, I'm going to do it this way, what do you think? ``` case class GlutenCost(value: Long, planId: Int) extends Cost { override def compare(that: Cost): Int = that match { case GlutenCost(thatValue, thatId) => if (value < thatValue || (value == thatValue && planId != thatId)) -1 else if (value > thatValue) 1 else 0 case _ => throw QueryExecutionErrors.cannotCompareCostWithTargetCostError(that.toString) } } ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
