ulysses-you commented on code in PR #6093:
URL: https://github.com/apache/incubator-gluten/pull/6093#discussion_r1645306069
##########
gluten-core/src/main/scala/org/apache/gluten/extension/columnar/OffloadSingleNode.scala:
##########
@@ -124,32 +124,10 @@ case class OffloadJoin() extends OffloadSingleNode with
LogLevelUtil {
}
plan match {
case plan: ShuffledHashJoinExec =>
- val left = plan.left
- val right = plan.right
logDebug(s"Columnar Processing for ${plan.getClass} is currently
supported.")
- BackendsApiManager.getSparkPlanExecApiInstance
- .genShuffledHashJoinExecTransformer(
- plan.leftKeys,
- plan.rightKeys,
- plan.joinType,
- TransformHints.getShuffleHashJoinBuildSide(plan),
- plan.condition,
- left,
- right,
- plan.isSkewJoin)
+ ShuffledHashJoinExecTransformerBase.from(plan)
case plan: SortMergeJoinExec =>
Review Comment:
I think the expected behavior for the smj is:
1. convert smj to shj if can offload shj and enable the config, otherwise 2
2. offload smj, otherwise 3
3. fallback smj
So, I think we miss the part 2: if we can not offload shj but support
offload smj.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
