zml1206 commented on code in PR #6093:
URL: https://github.com/apache/incubator-gluten/pull/6093#discussion_r1654831118
##########
gluten-core/src/main/scala/org/apache/gluten/extension/columnar/TransformHintRule.scala:
##########
@@ -421,7 +395,7 @@ case class AddTransformHintRule() extends Rule[SparkPlan] {
plan.leftKeys,
plan.rightKeys,
plan.joinType,
- TransformHints.getShuffleHashJoinBuildSide(plan),
Review Comment:
yea, but I think there is no need to convert here, because do validate does
not require buildside.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
