zml1206 commented on code in PR #6319:
URL: https://github.com/apache/incubator-gluten/pull/6319#discussion_r1663758338
##########
backends-velox/src/main/scala/org/apache/gluten/execution/FilterExecTransformer.scala:
##########
@@ -16,30 +16,11 @@
*/
package org.apache.gluten.execution
-import org.apache.spark.sql.catalyst.expressions.{And, Expression}
+import org.apache.spark.sql.catalyst.expressions.Expression
import org.apache.spark.sql.execution.SparkPlan
case class FilterExecTransformer(condition: Expression, child: SparkPlan)
extends FilterExecTransformerBase(condition, child) {
- // FIXME: Should use field "condition" to store the actual executed filter
expressions.
- // To make optimization easier (like to remove filter when it actually does
nothing)
Review Comment:
Should we remove this FIXME? @zhztheplayer
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
