ulysses-you commented on code in PR #6381:
URL: https://github.com/apache/incubator-gluten/pull/6381#discussion_r1673525407
##########
gluten-core/src/main/scala/org/apache/gluten/execution/WindowExecTransformer.scala:
##########
@@ -67,14 +67,10 @@ case class WindowExecTransformer(
}
override def requiredChildOrdering: Seq[Seq[SortOrder]] = {
- if (
- BackendsApiManager.getSettings.requiredChildOrderingForWindow()
- && GlutenConfig.getConf.veloxColumnarWindowType.equals("streaming")
- ) {
- // Velox StreamingWindow need to require child order.
- Seq(partitionSpec.map(SortOrder(_, Ascending)) ++ orderSpec)
+ if (GlutenConfig.getConf.veloxColumnarWindowType.equals("sort")) {
+ super.requiredChildOrdering
} else {
- Seq(Nil)
+ Seq(partitionSpec.map(SortOrder(_, Ascending)) ++ orderSpec)
Review Comment:
for 1, it's a good point, it seems the `WindowExecBase` has implemented
these methods since 3.3
for 2, the ck backend requires child ordering and before we did not remove
local sort before window
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
