zml1206 commented on code in PR #6381:
URL: https://github.com/apache/incubator-gluten/pull/6381#discussion_r1673534599
##########
gluten-core/src/main/scala/org/apache/gluten/execution/WindowExecTransformer.scala:
##########
@@ -67,14 +67,10 @@ case class WindowExecTransformer(
}
override def requiredChildOrdering: Seq[Seq[SortOrder]] = {
- if (
- BackendsApiManager.getSettings.requiredChildOrderingForWindow()
- && GlutenConfig.getConf.veloxColumnarWindowType.equals("streaming")
- ) {
- // Velox StreamingWindow need to require child order.
- Seq(partitionSpec.map(SortOrder(_, Ascending)) ++ orderSpec)
+ if (GlutenConfig.getConf.veloxColumnarWindowType.equals("sort")) {
+ super.requiredChildOrdering
} else {
- Seq(Nil)
+ Seq(partitionSpec.map(SortOrder(_, Ascending)) ++ orderSpec)
Review Comment:
I think we should retain requiredChildOrderingForWindow instead of using
velox configuration to control ck backend
although it has no effect by default value.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
