ulysses-you commented on PR #6420: URL: https://github.com/apache/incubator-gluten/pull/6420#issuecomment-2224352217
> Why. These are enable in `CH`, but doesn't mean they only could be used in `CH` Thank you @lgbo-ustc for review. This pr only mvoes rule which is dedicated for ch backend... If a rule can be reused for other backends, it should check `BackendsApiManager.getSettings.supportxxx`, e.g., `MergeTwoPhasesHashBaseAggregate` which is also only used for ch backend but live in core. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
