ulysses-you commented on PR #6420: URL: https://github.com/apache/incubator-gluten/pull/6420#issuecomment-2224590031
I think it's not a good story to say a rule is created for one backend but say it is not designed for that backend... and at least the tests should be added into gluten-ut module for all backends and skip backend which is not enabled by default. Do you mean `RewriteDateTimestampComparisonRule` and `CommonSubexpressionEliminateRule` are generic for velox backend ? If so ,i can leave them to core for now and see if we can help to make it work. BTW, the `RewriteToDateExpresstionRule` and `CountDistinctWithoutExpand` are bound to ch backend code and we can move them. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
