majetideepak commented on code in PR #6183:
URL: https://github.com/apache/incubator-gluten/pull/6183#discussion_r1677829359


##########
ep/build-velox/src/get_velox.sh:
##########
@@ -121,6 +121,45 @@ function process_setup_ubuntu {
 
 }
 
+function process_setup_centos9 {
+  # Allows other version of git already installed.
+  if [ -z "$(which git)" ]; then
+    dnf install -y -q --setopt=install_weak_deps=False git
+  fi
+  # make this function Reentrant
+  git checkout scripts/setup-centos9.sh
+  # need set BUILD_SHARED_LIBS flag for thrift
+  #sed -i "/cd fbthrift/{n;s/cmake_install -Denable_tests=OFF/cmake_install 
-Denable_tests=OFF -DBUILD_SHARED_LIBS=OFF/;}" scripts/setup-centos9.sh

Review Comment:
   remove commented command?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to