majetideepak commented on code in PR #6183:
URL: https://github.com/apache/incubator-gluten/pull/6183#discussion_r1677836032


##########
ep/build-velox/src/get_velox.sh:
##########
@@ -121,6 +121,45 @@ function process_setup_ubuntu {
 
 }
 
+function process_setup_centos9 {
+  # Allows other version of git already installed.
+  if [ -z "$(which git)" ]; then
+    dnf install -y -q --setopt=install_weak_deps=False git
+  fi
+  # make this function Reentrant
+  git checkout scripts/setup-centos9.sh
+  # need set BUILD_SHARED_LIBS flag for thrift
+  #sed -i "/cd fbthrift/{n;s/cmake_install -Denable_tests=OFF/cmake_install 
-Denable_tests=OFF -DBUILD_SHARED_LIBS=OFF/;}" scripts/setup-centos9.sh
+  # No need to re-install git.
+  sed -i 's/dnf_install ninja-build cmake curl ccache gcc-toolset-12 
git/dnf_install ninja-build cmake curl ccache gcc-toolset-12/' 
scripts/setup-centos9.sh
+  sed -i '/^function dnf_install/i\DEPENDENCY_DIR=${DEPENDENCY_DIR:-$(pwd)}' 
scripts/setup-centos9.sh
+  sed -i '/^dnf_install autoconf/a\dnf_install libxml2-devel libgsasl-devel 
libuuid-devel' scripts/setup-centos9.sh
+  sed -i '/^function install_gflags.*/i function install_openssl {\n  
wget_and_untar 
https://github.com/openssl/openssl/archive/refs/tags/OpenSSL_1_1_1s.tar.gz 
openssl \n cd openssl \n ./config no-shared && make depend && make && sudo make 
install \n cd ..\n}\n'     scripts/setup-centos9.sh
+  sed -i '/^  run_and_time install_fbthrift/a \  run_and_time install_openssl' 
scripts/setup-centos9.sh
+
+  if [ $ENABLE_HDFS == "ON" ]; then
+    sed -i '/^function install_gflags.*/i function install_libhdfs3 {\n cd 
"\${DEPENDENCY_DIR}"\n github_checkout oap-project/libhdfs3 master\n 
cmake_install\n}\n' scripts/setup-centos9.sh
+    sed -i '/^  run_and_time install_fbthrift/a \  run_and_time 
install_libhdfs3' scripts/setup-centos9.sh
+    sed -i '/^  dnf_install ninja-build/a\  dnf_install yasm\' 
scripts/setup-centos9.sh
+  fi
+  if [[ $BUILD_PROTOBUF == "ON" ]] || [[ $ENABLE_HDFS == "ON" ]]; then
+    sed -i '/cd protobuf/{n;s/\.\/configure --prefix=\/usr/\.\/configure 
CXXFLAGS="-fPIC" --prefix=\/usr\/local/;}' scripts/setup-centos9.sh
+  fi
+  sed -i "s/yum -y install/sudo yum -y install/" 
${VELOX_HOME}/scripts/setup-adapters.sh
+  if [ $ENABLE_S3 == "ON" ]; then
+    sed -i '/^  run_and_time install_fbthrift/a \ \ 
'${VELOX_HOME}/scripts'/setup-adapters.sh aws' scripts/setup-centos9.sh
+    # Maybe already installed.
+    #sed -i 's/rpm -i minio-20220526054841.0.0.x86_64.rpm/rpm -i --replacepkgs 
minio-20220526054841.0.0.x86_64.rpm/g' scripts/setup-adapters.sh

Review Comment:
   Remove commented command?
   Minio handling was recently simplified here 
https://github.com/facebookincubator/velox/pull/10373 to avoid conflicts.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to