FelixYBW commented on code in PR #6593:
URL: https://github.com/apache/incubator-gluten/pull/6593#discussion_r1691866809
##########
cpp/velox/shuffle/VeloxSortShuffleWriter.cc:
##########
@@ -278,7 +278,7 @@ uint32_t VeloxSortShuffleWriter::maxRowsToInsert(uint32_t
offset, uint32_t rows)
}
void VeloxSortShuffleWriter::acquireNewBuffer(int64_t memLimit, uint64_t
minSizeRequired) {
- auto size = std::max(std::min((uint64_t)memLimit >> 2, 64UL * 1024 * 1024),
minSizeRequired);
+ auto size = std::max(std::min<uint64_t>(memLimit >> 2, 64UL * 1024 * 1024),
minSizeRequired);
Review Comment:
we still need to cast memLimit to uint64_t from int64_t for >>.
Can you check if we can change the memLimit type to uint64_t?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
