FelixYBW commented on code in PR #6593:
URL: https://github.com/apache/incubator-gluten/pull/6593#discussion_r1692361900
##########
cpp/velox/shuffle/VeloxSortShuffleWriter.cc:
##########
@@ -161,7 +161,7 @@ arrow::Status VeloxSortShuffleWriter::insert(const
facebook::velox::RowVectorPtr
auto rows = maxRowsToInsert(rowOffset, remainingRows);
if (rows == 0) {
auto minSizeRequired = fixedRowSize_ ? fixedRowSize_.value() :
rowSizes_[rowOffset + 1] - rowSizes_[rowOffset];
- acquireNewBuffer(memLimit, minSizeRequired);
+ acquireNewBuffer((uint64_t)memLimit, minSizeRequired);
Review Comment:
Looks the callstack is large. Let's merge this one and clean the code later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
