taiyang-li commented on code in PR #6586:
URL: https://github.com/apache/incubator-gluten/pull/6586#discussion_r1692379245


##########
cpp-ch/local-engine/Common/CHUtil.cpp:
##########
@@ -496,8 +496,8 @@ std::map<std::string, std::string> 
BackendInitializerUtil::getBackendConfMap(con
     /// Parse backend configs from plan extensions
     do
     {
-        auto plan_ptr = std::make_unique<substrait::Plan>();
-        auto success = plan_ptr->ParseFromString(plan);
+        substrait::Plan sPlan;

Review Comment:
   use  the naming rule of clickhouse 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to