taiyang-li commented on code in PR #6586:
URL: https://github.com/apache/incubator-gluten/pull/6586#discussion_r1692380915
##########
cpp-ch/local-engine/Common/CHUtil.h:
##########
@@ -151,7 +153,7 @@ class BackendInitializerUtil
/// Initialize two kinds of resources
/// 1. global level resources like global_context/shared_context, notice
that they can only be initialized once in process lifetime
/// 2. session level resources like settings/configs, they can be
initialized multiple times following the lifetime of executor/driver
- static void init(const std::string & plan);
+ static void init(const std::string_view plan);
Review Comment:
why ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
