zhztheplayer commented on code in PR #6627:
URL: https://github.com/apache/incubator-gluten/pull/6627#discussion_r1696218122
##########
shims/spark32/src/main/scala/org/apache/spark/sql/execution/datasources/orc/OrcFileFormat.scala:
##########
@@ -83,7 +83,7 @@ class OrcFileFormat extends FileFormat with
DataSourceRegister with Serializable
options: Map[String, String],
files: Seq[FileStatus]): Option[StructType] = {
// Why if (false)? Such code requires comments when being written.
- if
("true".equals(sparkSession.sparkContext.getLocalProperty("isNativeAppliable"))
&& false) {
+ if ("true" ==
sparkSession.sparkContext.getLocalProperty("isNativeApplicable") && false) {
Review Comment:
Would it be more straight forward to use
`sparkSession.sparkContext.getLocalProperty("isNativeApplicable").toBoolean`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
