PHILO-HE commented on code in PR #6627:
URL: https://github.com/apache/incubator-gluten/pull/6627#discussion_r1696251040
##########
shims/spark32/src/main/scala/org/apache/spark/sql/execution/datasources/orc/OrcFileFormat.scala:
##########
@@ -83,7 +83,7 @@ class OrcFileFormat extends FileFormat with
DataSourceRegister with Serializable
options: Map[String, String],
files: Seq[FileStatus]): Option[StructType] = {
// Why if (false)? Such code requires comments when being written.
- if
("true".equals(sparkSession.sparkContext.getLocalProperty("isNativeAppliable"))
&& false) {
+ if ("true" ==
sparkSession.sparkContext.getLocalProperty("isNativeApplicable") && false) {
Review Comment:
@zhztheplayer, the property can be null and needs extra check if we use
that. Maybe, just keep the current change.
> I am still a little bit concerned about the use of these local properties.
Perhaps we can manage to remove them later some time.
Yes, it's not a good approach to use local property.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
