xumingming commented on code in PR #6689:
URL: https://github.com/apache/incubator-gluten/pull/6689#discussion_r1701982805
##########
backends-velox/src/main/scala/org/apache/gluten/extension/CollectRewriteRule.scala:
##########
@@ -48,6 +51,25 @@ case class CollectRewriteRule(spark: SparkSession) extends
Rule[LogicalPlan] {
out
}
+ private def needReplace(plan: LogicalPlan): Boolean = plan match {
+ // Do not replace collect in objectHashAggregate if disable objectHashAgg
collectRewrite. When
Review Comment:
The comment is more appropriate to be the comment of the method.
##########
shims/common/src/main/scala/org/apache/gluten/GlutenConfig.scala:
##########
@@ -1940,6 +1943,14 @@ object GlutenConfig {
.booleanConf
.createWithDefault(true)
+ val VELOX_OBJECTHASHAGG_COLLECT_REWRITE_ENABLED =
+
buildConf("spark.gluten.sql.columnar.backend.velox.objectHashAggregate.collect.rewrite.enabled")
Review Comment:
umm...the config name seems too long?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
