zml1206 commented on code in PR #6689:
URL: https://github.com/apache/incubator-gluten/pull/6689#discussion_r1702863635
##########
shims/common/src/main/scala/org/apache/gluten/GlutenConfig.scala:
##########
@@ -1940,6 +1943,14 @@ object GlutenConfig {
.booleanConf
.createWithDefault(true)
+ val VELOX_OBJECTHASHAGG_COLLECT_REWRITE_ENABLED =
+
buildConf("spark.gluten.sql.columnar.backend.velox.objectHashAggregate.collect.rewrite.enabled")
Review Comment:
> how about spark.gluten.sql.columnar.backend.velox.collectRewriteEnabled?
This is not global, it just disables objectHashAggregate's collect, although
currently there is only objectHashAggregate, there will be ambiguity in naming
this way. cc @zhztheplayer
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
