zml1206 commented on PR #6689: URL: https://github.com/apache/incubator-gluten/pull/6689#issuecomment-2270258100
> We have a `spark.gluten.expression.blacklist` to control expression fallbacks which could be used for avoid offloading collect_list / collect_set either. If all we wanted is to disable the rule, perhaps we can just set that option to `spark.gluten.expression.blacklist=collect_list,collect_set` or something. I may be wrong that we should have an individual option for this. `spark.gluten.expression.blacklist=collect_list,collect_set` and `spark.sql.optimizer.excludedRules=***.CollectRewriteRule` have the same effect, no matter what kind of aggregation they will fallback collect, but this new conf only fallback collect of objectHashAggregate. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
