xumingming commented on code in PR #6731:
URL: https://github.com/apache/incubator-gluten/pull/6731#discussion_r1706274900
##########
cpp/velox/CMakeLists.txt:
##########
@@ -582,9 +265,71 @@ if(BUILD_JEMALLOC)
endif()
target_link_libraries(velox PUBLIC gluten)
-add_velox_dependencies()
+
+add_library(facebook::velox STATIC IMPORTED)
+set_target_properties(
+ facebook::velox PROPERTIES IMPORTED_LOCATION
+ ${VELOX_BUILD_PATH}/lib/libvelox.a)
+
+if(BUILD_TESTS)
+ add_library(facebook::velox::dbgen STATIC IMPORTED)
Review Comment:
@PHILO-HE For the testing libraries, they are still separate libraries,
right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
