rui-mo commented on code in PR #6731:
URL: https://github.com/apache/incubator-gluten/pull/6731#discussion_r1706277712
##########
cpp/velox/CMakeLists.txt:
##########
@@ -582,9 +265,71 @@ if(BUILD_JEMALLOC)
endif()
target_link_libraries(velox PUBLIC gluten)
-add_velox_dependencies()
+
+add_library(facebook::velox STATIC IMPORTED)
+set_target_properties(
+ facebook::velox PROPERTIES IMPORTED_LOCATION
+ ${VELOX_BUILD_PATH}/lib/libvelox.a)
+
+if(BUILD_TESTS)
+ add_library(facebook::velox::dbgen STATIC IMPORTED)
+ set_target_properties(
+ facebook::velox::dbgen
+ PROPERTIES IMPORTED_LOCATION
+ "${VELOX_BUILD_PATH}/velox/tpch/gen/dbgen/libdbgen.a")
+ target_link_libraries(facebook::velox INTERFACE facebook::velox::dbgen)
+
+ add_library(facebook::velox::vector_test STATIC IMPORTED)
+ set_target_properties(
+ facebook::velox::vector_test
+ PROPERTIES
+ IMPORTED_LOCATION
+
"${VELOX_BUILD_PATH}/velox/vector/tests/utils/libvelox_vector_test_lib.a")
+
+ add_library(facebook::velox::dwio_common_test STATIC IMPORTED)
+ set_target_properties(
+ facebook::velox::dwio_common_test
+ PROPERTIES
+ IMPORTED_LOCATION
Review Comment:
Please consider using a helper function to simply the code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
