PHILO-HE commented on code in PR #6672:
URL: https://github.com/apache/incubator-gluten/pull/6672#discussion_r1709077078
##########
gluten-core/src/main/scala/org/apache/gluten/execution/BasicScanExecTransformer.scala:
##########
@@ -92,7 +101,12 @@ trait BasicScanExecTransformer extends LeafTransformSupport
with BaseDataSource
}
val validationResult = BackendsApiManager.getSettings
- .supportFileFormatRead(fileFormat, fields, getPartitionSchema.nonEmpty,
getInputFilePaths)
+ .supportFileFormatRead(
Review Comment:
`supportFileFormatRead` is not only checking file format now. Better to
change it to other name, like "validateScan" or some other a bit common name.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
