zhli1142015 commented on code in PR #6672:
URL: https://github.com/apache/incubator-gluten/pull/6672#discussion_r1708803452
##########
backends-velox/src/main/scala/org/apache/gluten/backendsapi/velox/VeloxBackend.scala:
##########
@@ -73,7 +74,14 @@ object VeloxBackendSettings extends BackendSettingsApi {
format: ReadFileFormat,
fields: Array[StructField],
partTable: Boolean,
+ rootPaths: Seq[String],
paths: Seq[String]): ValidationResult = {
+ if (
+ !rootPaths.isEmpty &&
!VeloxFileSystemValidationJniWrapper.supportedPaths(rootPaths.toArray)
Review Comment:
> Can we just extract the scheme to validate?
Velox API is designed to accept file path, now looks all file systems
validate the schema only. But I think it's better to align this with the velox
api to pass the file path. Now only one file path is validated.
> In addition, as local file system is always supported by Gluten + Velox.
Maybe, we can have a fast path to directly let validation pass on scala side
for such case.
Sure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
