kecookier commented on code in PR #5954:
URL: https://github.com/apache/incubator-gluten/pull/5954#discussion_r1714586143
##########
cpp/velox/substrait/SubstraitToVeloxPlan.cc:
##########
@@ -1712,19 +1733,6 @@ void SubstraitToVeloxPlanConverter::separateFilters(
for (const auto& scalarFunction : scalarFunctions) {
auto filterNameSpec = SubstraitParser::findFunctionSpec(functionMap_,
scalarFunction.function_reference());
auto filterName = SubstraitParser::getNameBeforeDelimiter(filterNameSpec);
- // Add all decimal filters to remaining functions because their pushdown
are not supported.
- if (format == dwio::common::FileFormat::ORC &&
scalarFunction.arguments().size() > 0) {
Review Comment:
The ORC format already supports short-decimal predicate pushdown.
@jiangjiangtian Can you help test this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
