Re: [PR] [GLUTEN-5953][VL] Prevent pushdown filters with unsupported data types to scan node [incubator-gluten]

Wed, 14 Aug 2024 00:02:49 -0700 


jiangjiangtian commented on code in PR #5954:
URL: https://github.com/apache/incubator-gluten/pull/5954#discussion_r1716404944


##########
cpp/velox/substrait/SubstraitToVeloxPlan.cc:
##########
@@ -1712,19 +1733,6 @@ void SubstraitToVeloxPlanConverter::separateFilters(
   for (const auto& scalarFunction : scalarFunctions) {
     auto filterNameSpec = SubstraitParser::findFunctionSpec(functionMap_, 
scalarFunction.function_reference());
     auto filterName = SubstraitParser::getNameBeforeDelimiter(filterNameSpec);
-    // Add all decimal filters to remaining functions because their pushdown 
are not supported.
-    if (format == dwio::common::FileFormat::ORC && 
scalarFunction.arguments().size() > 0) {

Review Comment:
   I verify that short-decimal predicate can be pushdown, as follows:
   
![image](https://github.com/user-attachments/assets/864248c1-9fc9-4fb0-8003-6a4104b24e64)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to