jinchengchenghh commented on code in PR #6793:
URL: https://github.com/apache/incubator-gluten/pull/6793#discussion_r1714625050
##########
cpp/core/config/GlutenConfig.cc:
##########
@@ -16,12 +16,17 @@
*/
#include <jni.h>
-
+#include <optional>
+#include <regex>
#include "compute/ProtobufUtils.h"
#include "config.pb.h"
#include "jni/JniError.h"
namespace gluten {
+
+const std::string REDACTED_VALUE = "*********(redacted)";
+const std::string REGEX_REDACT_KEY = "spark.gluten.redaction.regex";
Review Comment:
Duplicated
https://github.com/apache/incubator-gluten/pull/6793/files#diff-738908e381e317bdb343354905fd64c5af6c4a58e035376d5dbd2df5313b4a06R67
##########
cpp/core/config/GlutenConfig.cc:
##########
@@ -34,12 +39,28 @@ parseConfMap(JNIEnv* env, const uint8_t* planData, const
int32_t planDataLength)
return sparkConfs;
}
+std::optional<std::regex> getRedactionRegex(const
std::unordered_map<std::string, std::string>& conf) {
+ auto it = conf.find(REGEX_REDACT_KEY);
Review Comment:
Please move this one to anonymous namespace.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
