ArnavBalyan commented on code in PR #6793:
URL: https://github.com/apache/incubator-gluten/pull/6793#discussion_r1715045700
##########
shims/common/src/main/scala/org/apache/gluten/GlutenConfig.scala:
##########
@@ -673,7 +674,8 @@ object GlutenConfig {
// gcs config
SPARK_GCS_STORAGE_ROOT_URL,
SPARK_GCS_AUTH_TYPE,
- SPARK_GCS_AUTH_SERVICE_ACCOUNT_JSON_KEYFILE
+ SPARK_GCS_AUTH_SERVICE_ACCOUNT_JSON_KEYFILE,
+ GLUTEN_REGEX_LOG_REDACTION
Review Comment:
Thanks, I was trying to do this, then realized some compatibility problems
with C++ `regex` library vs Scala `matching` library used by Spark.
For example: Spark typically uses something like
`(?i)secret\|password\|token\|access[.]key`, but this fails in C++ regex
library because `(?i)` is not supported and users need to represent the regex
in a different manner. To prevent such conflicts, for now I had created a
different config specific to gluten. I agree, this is not the most elegant way,
can switch to single config as well, let me know thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
