zhztheplayer commented on code in PR #6837:
URL: https://github.com/apache/incubator-gluten/pull/6837#discussion_r1716504670
##########
gluten-core/src/main/scala/org/apache/gluten/expression/ExpressionMappings.scala:
##########
@@ -354,6 +354,5 @@ object ExpressionMappings {
.toMap[Class[_], String]
}
- var expressionExtensionTransformer: ExpressionExtensionTrait =
- DefaultExpressionExtensionTransformer()
+ var expressionExtensionTransformer: ExpressionExtensionTrait = _
Review Comment:
I'd suggest to use getter and setters to avoid directly accessing the
variable.
In the setter, we can do a check to make sure it was not set.
Similarly in the getter, we can do a check to make sure it was set.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
