zhztheplayer commented on code in PR #6837:
URL: https://github.com/apache/incubator-gluten/pull/6837#discussion_r1717682650
##########
gluten-core/src/main/scala/org/apache/gluten/expression/ExpressionMappings.scala:
##########
@@ -354,6 +354,16 @@ object ExpressionMappings {
.toMap[Class[_], String]
}
- var expressionExtensionTransformer: ExpressionExtensionTrait =
- DefaultExpressionExtensionTransformer()
+ private var expressionExtensionTransformer: Option[ExpressionExtensionTrait]
= None
+
+ def getExpressionExtensionTransformer: ExpressionExtensionTrait = {
+ expressionExtensionTransformer.getOrElse(new
DefaultExpressionExtensionTransformer)
Review Comment:
Can we throw when it's none? Otherwise we don't make it sure whether the
change (setting it in executor side) takes effect. Say if we throw when none,
then we must set it in both driver and executor sides otherwise the application
will fail by error.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
