zhztheplayer commented on code in PR #6962:
URL: https://github.com/apache/incubator-gluten/pull/6962#discussion_r1726170128
##########
gluten-data/src/main/java/org/apache/gluten/vectorized/ArrowWritableColumnVector.java:
##########
@@ -1255,9 +1266,8 @@ void setNull(int rowId) {
throw new UnsupportedOperationException();
}
- void setNotNull(int rowId) {
- throw new UnsupportedOperationException();
- }
+ // Arrow not need to setNotNull, set the valus is enough.
+ void setNotNull(int rowId) {}
Review Comment:
The class is abstract and the method should be overridable by impl classes.
See
https://github.com/apache/incubator-gluten/blob/ed3d333c7c357e95f6736f378c972b714bdfb420/gluten-data/src/main/java/org/apache/gluten/vectorized/ArrowWritableColumnVector.java#L1913
as example.
~~And abstract class `ArrowVectorWriter` doesn't likely have to be abstract.
Could make it an interface as it almost doesn't override anything from the
hierarchy. ~~ (needs more design)
##########
gluten-data/src/main/java/org/apache/gluten/vectorized/ArrowWritableColumnVector.java:
##########
@@ -1255,9 +1266,8 @@ void setNull(int rowId) {
throw new UnsupportedOperationException();
}
- void setNotNull(int rowId) {
- throw new UnsupportedOperationException();
- }
+ // Arrow not need to setNotNull, set the valus is enough.
+ void setNotNull(int rowId) {}
Review Comment:
The class is abstract and the method should be overridable by impl classes.
See
https://github.com/apache/incubator-gluten/blob/ed3d333c7c357e95f6736f378c972b714bdfb420/gluten-data/src/main/java/org/apache/gluten/vectorized/ArrowWritableColumnVector.java#L1913
as example.
~~And abstract class `ArrowVectorWriter` doesn't likely have to be abstract.
Could make it an interface as it almost doesn't override anything from the
hierarchy.~~ (needs more design)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
