jinchengchenghh commented on code in PR #6962:
URL: https://github.com/apache/incubator-gluten/pull/6962#discussion_r1728180120
##########
gluten-data/src/main/java/org/apache/gluten/vectorized/ArrowWritableColumnVector.java:
##########
@@ -1255,9 +1266,8 @@ void setNull(int rowId) {
throw new UnsupportedOperationException();
}
- void setNotNull(int rowId) {
- throw new UnsupportedOperationException();
- }
+ // Arrow not need to setNotNull, set the valus is enough.
+ void setNotNull(int rowId) {}
Review Comment:
writer does not have the `setDecimal` function, I copied most code from
https://github.com/apache/spark/blob/master/sql/core/src/main/java/org/apache/spark/sql/execution/vectorized/WritableColumnVector.java#L429
but is different in putByteArray, because Arrow DecimalVector does not support
put byte array range.
Put the all bytes is final function in Spark.
```
public abstract int putByteArray(int rowId, byte[] value, int offset, int
count);
public final int putByteArray(int rowId, byte[] value) {
return putByteArray(rowId, value, 0, value.length);
}
```
I will add a test for it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
