baibaichen commented on code in PR #7176:
URL: https://github.com/apache/incubator-gluten/pull/7176#discussion_r1751182154
##########
cpp-ch/local-engine/Common/CHUtil.cpp:
##########
@@ -315,6 +316,16 @@ DB::Block
BlockUtil::concatenateBlocksMemoryEfficiently(std::vector<DB::Block> &
return out;
}
+String BlockUtil::dumpBlock(const DB::Block & block)
Review Comment:
How are about moving to `BlockTypeUtils.h/.cpp` ?
##########
cpp-ch/local-engine/local_engine_jni.cpp:
##########
@@ -166,6 +167,8 @@ JNIEXPORT jint JNI_OnLoad(JavaVM * vm, void * /*reserved*/)
local_engine::BroadCastJoinBuilder::init(env);
local_engine::CacheManager::initJNI(env);
+ DB::registerFormats();
Review Comment:
Why does this PR need to call `DB:: tradeFormats()`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
