baibaichen commented on code in PR #7176:
URL: https://github.com/apache/incubator-gluten/pull/7176#discussion_r1751315274
##########
cpp-ch/local-engine/Common/CHUtil.cpp:
##########
@@ -315,6 +316,16 @@ DB::Block
BlockUtil::concatenateBlocksMemoryEfficiently(std::vector<DB::Block> &
return out;
}
+String BlockUtil::dumpBlock(const DB::Block & block)
Review Comment:
If dumping is just for debug aid, I think we should move it to
`DebugUtils.h/cpp`, and put it to `debug` namespace. In product code, we should
put it into` #ifdef NDEBUG .. #endif`. e.g.
``` C++
#ifdef NDEBUG
debug::dumpxxx();
#endif
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
