PHILO-HE commented on PR #7209: URL: https://github.com/apache/incubator-gluten/pull/7209#issuecomment-2345857275
> @PHILO-HE thanks for your reviewing! Actually I also want to figure out why glog is linked in your pr [4434](https://github.com/apache/incubator-gluten/pull/4434) . This pr fix issue when vcpkg is on so I put linking glog in the `if(ENABLE_GLUTEN_VCPKG) `conditional statement. @JinHelin404, I remember linking glog is necessary when debug build is enabled (at least it's true at that code point). The issue of both statically and dynamically linking can happen when static glog lib is used, regardless of vcpkg is enabled or not (enabling vcpkg definitely makes static glog lib be used). I think we can remove the below check to also hide those conflict symbols when vcpkg is not enabled: https://github.com/apache/incubator-gluten/blob/main/cpp/core/CMakeLists.txt#L216. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
