JinHelin404 commented on PR #7209: URL: https://github.com/apache/incubator-gluten/pull/7209#issuecomment-2346348200
> The issue of both statically and dynamically linking can happen when static glog lib is used, regardless of vcpkg is enabled or not (enabling vcpkg definitely makes static glog lib be used). I think we can remove the below check to also hide those conflict symbols when vcpkg is not enabled: @PHILO-HE Thanks for your advice. I agree that we can always hide these symbols and I have fixed this pr. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
