Henry2SS commented on PR #7476: URL: https://github.com/apache/incubator-gluten/pull/7476#issuecomment-2406736471
> @Henry2SS, thanks for your pr! This piece of scala code is for making Gluten/Velox consistent with Spark. Seems the current Velox code doesn't have the consistent white spaces definition? Could you check further? There is a method called `isUnicodeWhiteSpace` in `velox/functions/lib/string/StringImpl.h`. And I noticed that, from https://github.com/facebookincubator/velox/pull/7377 this PR, the author proposed different corner cases for Presto and Spark on CAST, including removeWhiteSpaces. Unfortunately, I don't have much knowledge about this, please confirm. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
