jackylee-ch commented on code in PR #7476:
URL: https://github.com/apache/incubator-gluten/pull/7476#discussion_r1810503101
##########
backends-velox/src/main/scala/org/apache/gluten/backendsapi/velox/VeloxSparkPlanExecApi.scala:
##########
@@ -706,50 +706,6 @@ class VeloxSparkPlanExecApi extends SparkPlanExecApi {
VeloxGetStructFieldTransformer(substraitExprName, childTransformer,
ordinal, original)
}
- /**
- * To align with spark in casting string type input to other types, add trim
node for trimming
- * space or whitespace. See spark's Cast.scala.
- */
- override def genCastWithNewChild(c: Cast): Cast = {
- // scalastyle:off nonascii
- // Common whitespace to be trimmed, including: ' ', '\n', '\r', '\f', etc.
- val trimWhitespaceStr = " \t\n\u000B\u000C\u000D\u001C\u001D\u001E\u001F"
- // Space separator.
- val trimSpaceSepStr = "\u1680\u2008\u2009\u200A\u205F\u3000" +
- ('\u2000' to '\u2006').toList.mkString
- // Line separator.
- val trimLineSepStr = "\u2028"
Review Comment:
Maybe add a config, default false, for it? A little worried about the result
diff if we haven't tested the total case between vanilla spark and velox.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
