zhztheplayer commented on code in PR #7474:
URL: https://github.com/apache/incubator-gluten/pull/7474#discussion_r1796581015
##########
.github/workflows/velox_backend.yml:
##########
@@ -56,19 +56,29 @@ jobs:
build-native-lib-centos-7:
runs-on: ubuntu-20.04
container: apache/gluten:vcpkg-centos-7
+ env:
+ VELOX_BUILD_PATH: "./ep/build-velox/build/velox_ep/_build/release/"
steps:
- uses: actions/checkout@v2
- name: Generate cache key
run: |
- echo ${{ hashFiles('./ep/build-velox/src/**', './dev/**', './cpp/*',
'./.github/workflows/*') }} > cache-key
+ echo ${{ hashFiles('./ep/build-velox/src/**', './dev/**',
'./.github/workflows/velox_backend.yml') }} > cache-key
Review Comment:
> ./ep/build-velox/src/**
~~I think we could change our OAP Velox dependency from branches to tags
while landing this PR. Branches can be updated without invalidating the new
cache.~~
Edit: Similar issue already existed even with current cache policy. It's
fine till now so no need to put to high priority.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
