PHILO-HE commented on code in PR #7474:
URL: https://github.com/apache/incubator-gluten/pull/7474#discussion_r1796628520
##########
.github/workflows/velox_backend.yml:
##########
@@ -56,19 +56,29 @@ jobs:
build-native-lib-centos-7:
runs-on: ubuntu-20.04
container: apache/gluten:vcpkg-centos-7
+ env:
+ VELOX_BUILD_PATH: "./ep/build-velox/build/velox_ep/_build/release/"
steps:
- uses: actions/checkout@v2
- name: Generate cache key
run: |
- echo ${{ hashFiles('./ep/build-velox/src/**', './dev/**', './cpp/*',
'./.github/workflows/*') }} > cache-key
+ echo ${{ hashFiles('./ep/build-velox/src/**', './dev/**',
'./.github/workflows/velox_backend.yml') }} > cache-key
Review Comment:
@zhztheplayer, yes, this is a potential issue. But before a velox rebase
branch is finalized, we may still need oap/velox to hold it as a branch that
allows updating (e.g., needs some fixes due to Gluten CI failure). So maybe, we
should just have a internal convention to forbid updating oap/velox branch once
it is already referenced by Gluten code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
